fix 8.4 deprecation in traceresponse propagator #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
============================================
- Coverage 79.75% 78.76% -1.00%
- Complexity 249 605 +356
============================================
Files 32 60 +28
Lines 988 2585 +1597
============================================
+ Hits 788 2036 +1248
- Misses 200 549 +349
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisLightfootWild
approved these changes
Jan 6, 2025
weslenteche
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: open-telemetry/opentelemetry-php#1464